From 3161671a7d2d77c464f12fe67f57c73be4c6ec19 Mon Sep 17 00:00:00 2001
From: rsuntk <rsuntk@yukiprjkt.my.id>
Date: Tue, 2 Sep 2025 19:24:28 +0700
Subject: [PATCH] kernel: stop intercepting devpts inode permission via LSM

* Somehow, it just does not work properly. (sometimes)

Signed-off-by: rsuntk <rsuntk@yukiprjkt.my.id>
---
 kernel/core_hook.c | 13 -------------
 kernel/sucompat.c  | 28 ++++++++--------------------
 2 files changed, 8 insertions(+), 33 deletions(-)

diff --git a/kernel/core_hook.c b/kernel/core_hook.c
index 0464a3ce..698534b9 100644
--- a/kernel/core_hook.c
+++ b/kernel/core_hook.c
@@ -1439,23 +1439,10 @@ static int ksu_task_fix_setuid(struct cred *new, const struct cred *old,
 }
 
 #ifndef MODULE
-extern int __ksu_handle_devpts(struct inode *inode);
-static int ksu_inode_permission(struct inode *inode, int mask)
-{
-	if (unlikely(inode->i_sb && inode->i_sb->s_magic == DEVPTS_SUPER_MAGIC)) {
-#ifdef CONFIG_KSU_DEBUG
-		pr_info("%s: devpts inode accessed with mask: %x\n", __func__, mask);
-#endif
-		__ksu_handle_devpts(inode);
-	}
-	return 0;
-}
-
 static struct security_hook_list ksu_hooks[] = {
 	LSM_HOOK_INIT(task_prctl, ksu_task_prctl),
 	LSM_HOOK_INIT(inode_rename, ksu_inode_rename),
 	LSM_HOOK_INIT(task_fix_setuid, ksu_task_fix_setuid),
-	LSM_HOOK_INIT(inode_permission, ksu_inode_permission),
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 10, 0) ||	\
 	defined(CONFIG_IS_HW_HISI) ||	\
 	defined(CONFIG_KSU_ALLOWLIST_WORKAROUND)
diff --git a/kernel/sucompat.c b/kernel/sucompat.c
index d207055e..1f8ef4fb 100644
--- a/kernel/sucompat.c
+++ b/kernel/sucompat.c
@@ -242,8 +242,14 @@ int ksu_handle_execve_sucompat(int *fd, const char __user **filename_user,
 	return 0;
 }
 
-static int ksu_inline_handle_devpts(struct inode *inode)
+int ksu_handle_devpts(struct inode *inode)
 {
+
+#ifndef CONFIG_KSU_KPROBES_HOOK
+	if (!ksu_sucompat_hook_state)
+		return 0;
+#endif
+
 	if (!current->mm) {
 		return 0;
 	}
@@ -272,22 +278,6 @@ static int ksu_inline_handle_devpts(struct inode *inode)
 	return 0;
 }
 
-int __ksu_handle_devpts(struct inode *inode)
-{
-#ifndef CONFIG_KSU_KPROBES_HOOK
-	if (!ksu_sucompat_hook_state) {
-		return 0;
-	}
-#endif
-	return ksu_inline_handle_devpts(inode);
-}
-
-// dead code, we are phasing out ksu_handle_devpts for LSM hooks.
-int __maybe_unused ksu_handle_devpts(struct inode *inode)
-{
-	return 0;
-}
-
 #ifdef CONFIG_KSU_KPROBES_HOOK
 
 static int faccessat_handler_pre(struct kprobe *p, struct pt_regs *regs)
@@ -334,7 +324,7 @@ static int pts_unix98_lookup_pre(struct kprobe *p, struct pt_regs *regs)
 	inode = (struct inode *)PT_REGS_PARM2(regs);
 #endif
 
-	return ksu_inline_handle_devpts(inode);
+	return ksu_handle_devpts(inode);
 }
 #else
 static struct kprobe *su_kps[5];
@@ -380,9 +370,7 @@ void ksu_sucompat_init(void)
 	su_kps[2] = init_kprobe(SYS_FACCESSAT_SYMBOL, faccessat_handler_pre);
 	su_kps[3] = init_kprobe(SYS_NEWFSTATAT_SYMBOL, newfstatat_handler_pre);
 	su_kps[4] = init_kprobe(SYS_FSTATAT64_SYMBOL, newfstatat_handler_pre);
-#ifdef MODULE
 	su_kps[5] = init_kprobe("pts_unix98_lookup", pts_unix98_lookup_pre);
-#endif
 #else
 	ksu_sucompat_hook_state = true;
 	pr_info("ksu_sucompat init\n");